Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fusion] @semanticNonNull composition support #7731

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fusion] @semanticNonNull composition support #7731

wants to merge 3 commits into from

Conversation

tobias-tengler
Copy link
Collaborator

This PR implements the composition of semantic non-null with non-null and nullable types.

A B Result Reason
Semantic Non-Null Semantic Non-Null Semantic Non-Null -
Semantic Non-Null Non-Null Semantic Non-Null The field will still be returned in the Semantic Non-Null case
Semantic Non-Null Nullable Nullable null is an expected value
Non-Null Non-Null Non-Null -
Non-Null Nullable Nullable null is an expected value
Nullable Nullable Nullable -

@tobias-tengler tobias-tengler force-pushed the tte/semantic-non-null-fusion-composition branch from 27c3631 to 14c9b73 Compare November 17, 2024 09:56
@tobias-tengler tobias-tengler marked this pull request as ready for review November 17, 2024 09:56
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Nov 17, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (c477e13) to head (2bd18d4).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7731      +/-   ##
==========================================
+ Coverage   74.32%   74.34%   +0.01%     
==========================================
  Files        2860     2868       +8     
  Lines      149842   149976     +134     
  Branches    17411    17433      +22     
==========================================
+ Hits       111373   111496     +123     
- Misses      32671    32674       +3     
- Partials     5798     5806       +8
Flag Coverage Δ
unittests 74.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🌶️ hot chocolate 👓 ready-for-review The PR is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-tengler @michaelstaib